Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keras model_file expects str instead of Path. fixes #9 #22

Closed
wants to merge 1 commit into from
Closed

keras model_file expects str instead of Path. fixes #9 #22

wants to merge 1 commit into from

Conversation

mbhall88
Copy link

I am aware that #10 already addresses this issue. However, the way that PR goes about fixing the problem in #9 (in my opinion) is not ideal.

load_model expects a str or "h5py.File or h5py.Group object from which to load the model". @rrwick handles the model files internally with the pathlib.Path class which is an obvious design choice as these objects are indeed paths and therefore the added functionality this class brings within python is something Ryan uses a lot in the code.

I don't think changing the function find_model to return a str instead of a Path to satisfy the single use of keras.load_model is warranted.

@mbhall88
Copy link
Author

fixed in e053457. PR no longer required.

@mbhall88 mbhall88 closed this Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant