ClickHouse JDBC driver 0 5+ support#149
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds support for ClickHouse JDBC driver version 0.5+ while maintaining backward compatibility with version 0.4.x. The driver API changed significantly between these versions, requiring updates to how dependencies are loaded and how data is imported.
Changes:
- Updated ClickHouse JDBC driver loading to include SLF4J dependencies required by version 0.5+
- Added compatibility layer for data import that detects driver version and uses appropriate API
- Simplified jar file ignore patterns and updated documentation
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/support/jars/.gitignore | Simplified ignore patterns to match all jar files |
| spec/spec_helper.rb | Added SLF4J jar loading, updated create_table signatures, added global JDBC adapter patches |
| spec/rake_tasks.rb | Added version detection and compatibility layer for ClickHouse data import API |
| RUNNING_TESTS.rdoc | Updated documentation to reference clickhouse-jdbc-*-all.jar instead of *-shaded.jar |
| AGENTS.md | Added mise tool configuration guidelines (unrelated to PR purpose) |
| .rubocop.yml | Renamed Lint/EndAlignment to Layout/EndAlignment (unrelated to PR purpose) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.