Extract set_driver_properties method#150
Merged
Merged
Conversation
and initialize ClickHouse missing password as ''
There was a problem hiding this comment.
Pull request overview
This pull request refactors driver-specific JDBC property configuration by extracting a set_driver_properties method, making it easier to add database-specific properties. It also adds ClickHouse support by ensuring the JdbcPassword property is always set, as required by the ClickHouse JDBC driver.
Changes:
- Extracted driver-specific property configuration into a
set_driver_propertiespattern - Moved Oracle prefetch row configuration to a dedicated
set_oracle_propertiesmethod - Added
set_clickhouse_propertiesto initialize empty password when none is provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and initialize ClickHouse missing password as ''