Skip the patch for moderm JRuby vers#2413
Open
ryudoawaru wants to merge 1 commit into
Open
Conversation
Contributor
|
It would be very helpful for JRuby users to complete this simple improvement by merging the PR. |
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Apr 8, 2026
JRuby before 9.3.0.0 does not define ObjectSpace::WeakMap#values natively (jruby/jruby#6267). Patch it using JRuby's field_reader to access the underlying Java map. Skip the patch when #values is already defined (JRuby 9.3.0.0 or higher via jruby/jruby#6683). Based on the approaches explored in rsim#2360 and rsim#2413, but guards with method_defined?(:values) instead of a version check so the workaround is skipped automatically once JRuby provides the method natively. Co-Authored-By: Ryudo Awaru <ryudoawaru@gmail.com> Co-Authored-By: Thomas Steinhausen <27787+iaddict@users.noreply.github.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By the comment here, I believe it's not necessary to apply the patch for moderm JRuby versions.