You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed there are fixes in release80 branch but there is no release done that contains those fixes. Is it clear to someone how/when they are released? Will the release contain this fix? What about the currently unnecessary # Workaround for jruby/jruby#6267 etc
For awareness: JDBCConnection::Cursor#select_statement? has already been added on master in 0929019b with a simpler implementation:
defselect_statement?
!@raw_result_set.nil?end
On master this works because an earlier refactor (4d7e9fe8 — "Use createStatement for DDL / PL/SQL in JDBC prepare") changed Cursor#exec to assign @raw_result_set only when @raw_statement.execute returns true (i.e. the first result is a ResultSet), which is JDBC's authoritative SELECT signal. On release80, exec still calls executeQuery unconditionally, so the same one-liner wouldn't distinguish SELECT from DML there — which is why this PR's regex-on-SQL workaround is needed on that branch.
So master doesn't need this change. Whether to merge this PR as-is on release80, or to backport 4d7e9fe8 + 0929019b instead, is a separate release80-only decision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method was missed for the JDBC implementation of class Cursor
Fixes issue #2470