Test: #2521 after #2535#2537
Closed
yahonda wants to merge 4 commits into
Closed
Conversation
…ribe Replace the 4-way UNION ALL query across all_tables, all_views, and all_synonyms with a single all_objects query for the common TABLE/VIEW path. Synonym targets are resolved via a second all_synonyms query only when needed. - Add ORDER BY to preserve lookup priority (table, view, owner synonym, public synonym) - Add regression test covering table, view, private synonym and public synonym resolution for the same underlying table - Grant CREATE/DROP PUBLIC SYNONYM to test users Refs rsim#2429 Co-Authored-By: N.lohitha <lohithavarma36@gmail.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Fix the adapter to support self.table_name = "table@db_link" end-to-end: - describe (connection.rb): query all_tables@link / all_views@link - column_definitions: append @link to all_tab_cols, all_col_comments - pk_and_sequence_for: append @link to all_sequences, all_constraints; add .to_s for Symbol - table_exists?: add return false - visit_Arel_Table (oracle_common.rb): @link in FROM only - quote_table_name: keep existing strip behavior Add database link spec (oracle_enhanced_remote_link) to test remote table access via RemoteEmployee model. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Closing the test has been done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify PR #2521 (all_objects query) applies cleanly after PR #2535 (db link support) merges. Conflict in create_oracle_enhanced_users.sql resolved by combining both grant sets.