Fail the devcontainer CI job when rake spec fails#2801
Merged
Conversation
The runCmd is a multi-line bash script with no `set -e`, so a non-zero exit from `bundle exec rake spec` does not propagate. The script keeps running, executes `bundle exec rubocop`, and the script's exit code becomes RuboCop's exit code. As long as RuboCop is clean, GitHub Actions marks the job green even when rspec is red. Run 26084989755 hit this: 4 ORA-01805 failures in rake spec, but the job was reported as success because RuboCop passed. Add `set -e` so the first non-zero exit aborts the script and surfaces through the action as a job failure.
2 tasks
yahonda
added a commit
to rsim/ruby-plsql
that referenced
this pull request
May 19, 2026
`.github/workflows/devcontainer.yml`'s `runCmd` is a multi-line bash script with no `set -e`, so a non-zero exit from `bundle exec rake spec` does not propagate. The script keeps running, executes `bundle exec rubocop`, and the script's exit code becomes RuboCop's exit code. As long as RuboCop is clean, GitHub Actions marks the job green even when rspec is red. Add `set -e` so the first non-zero exit aborts the script and surfaces through `devcontainers/ci` as a job failure. Mirrors rsim/oracle-enhanced#2801. Scope kept intentionally minimal: one `set -e` line. `-u` risks tripping on unset-but-harmless variables and the immediate bug is just exit-code propagation. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/devcontainer.yml'srunCmdis a multi-line bash script with noset -e, so a non-zero exit frombundle exec rake specdoes not propagate. The script keeps running, executesbundle exec rubocop, and the script's exit code becomes RuboCop's exit code. As long as RuboCop is clean, GitHub Actions marks the job green even when rspec is red.Run 26084989755 hit this: 4 ORA-01805 failures in
rake spec, but the job was reported as success because RuboCop passed.Add
set -eso the first non-zero exit aborts the script and surfaces throughdevcontainers/cias a job failure.Notes
devcontainerworkflow dispatch on master will correctly report green; before Align dev container Instant Client TZ data with Oracle server #2799, it would correctly report red.set -eline. Could go further withset -euo pipefail, but-urisks tripping on unset-but-harmless variables and the immediate bug is just exit-code propagation.Test plan
devcontainerworkflow on master (still without Align dev container Instant Client TZ data with Oracle server #2799) and confirm the job goes red on the ORA-01805 failures.