Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #66: Feature-Request-API-To-Provide-All-Cities #68

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

KvngJamesNG
Copy link
Collaborator

@KvngJamesNG KvngJamesNG commented Oct 29, 2024

GET API request for cities
image

@KvngJamesNG KvngJamesNG requested a review from rt4914 as a code owner October 29, 2024 15:56
@KvngJamesNG KvngJamesNG linked an issue Oct 29, 2024 that may be closed by this pull request
@KvngJamesNG KvngJamesNG removed the request for review from rt4914 October 29, 2024 15:56
@KvngJamesNG KvngJamesNG self-assigned this Oct 29, 2024
@KvngJamesNG KvngJamesNG requested a review from rt4914 October 29, 2024 15:56
Copy link
Owner

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KvngJamesNG This is not the correct way of creating APIs in rails.

We generally create namespace api inside which we create the actual api.

Have a look at this video: https://youtu.be/tLxFEMNHUJA?si=vF8a6euQZ3lw7oZv

Or this article: https://medium.com/swlh/how-to-build-an-api-with-ruby-on-rails-28e27d47455a

@rt4914 rt4914 removed their assignment Nov 3, 2024
@KvngJamesNG
Copy link
Collaborator Author

KvngJamesNG commented Nov 3, 2024

@rt4914 Thank you for the observation I will reconfirm and revert as soon as possible.
Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: API to provide all cities
2 participants