Feature: Add ButtonGroup, RadioButton, Tag, Spacer and Slider components based on Espresso by Frappe #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1ink0
changed the title
b1ink0
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces five new UI components (ButtonGroup, RadioButton, Tag, Spacer, and Slider) based on the Espresso by Frappe design system, along with a refactored Divider component. The changes add comprehensive component libraries with Storybook stories for documentation and testing.
- Adds new reusable components with configurable props for size, variant, theme, and behavior
- Refactors the Divider component to support slot-based content rendering instead of action buttons
- Extends the Tooltip component with an
openprop for controlled visibility
Reviewed changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 19 comments.
Show a summary per file
| File | Description |
|---|---|
packages/frappe-ui-react/src/components/tooltip/types.ts |
Adds open prop to TooltipProps for controlled tooltip visibility |
packages/frappe-ui-react/src/components/tooltip/tooltip.tsx |
Implements controlled tooltip behavior using the open prop |
packages/frappe-ui-react/src/components/tag/* |
New Tag component with removable functionality and variant support |
packages/frappe-ui-react/src/components/spacer/* |
New Spacer component for flexible spacing in horizontal/vertical layouts |
packages/frappe-ui-react/src/components/slider/* |
New Slider component supporting single value and range selection with tooltips |
packages/frappe-ui-react/src/components/radioButton/* |
New RadioButton component with customizable options and disabled states |
packages/frappe-ui-react/src/components/buttonGroup/* |
New ButtonGroup component for grouping related buttons |
packages/frappe-ui-react/src/components/divider/* |
Refactored to use slot-based rendering pattern instead of action buttons |
packages/frappe-ui-react/src/components/index.ts |
Exports new components for public API |
packages/frappe-ui-react/src/components/buttonGroup/buttonGroup.tsx
Outdated
Show resolved
Hide resolved
packages/frappe-ui-react/src/components/radioButton/radioButton.stories.tsx
Outdated
Show resolved
Hide resolved
packages/frappe-ui-react/src/components/divider/divider.stories.tsx
Outdated
Show resolved
Hide resolved
mohdsayed
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds new components based on Espresso by Frappe Figma design.
RadioButton.Demo.mp4
Tag.Demo.mp4
Slider.Demo.mp4
Relevant Technical Choices
Testing Instructions
Additional Information:
Screenshot/Screencast
Checklist
Fixes #