Skip to content

Conversation

@jbpextra
Copy link
Contributor

@jbpextra jbpextra commented May 17, 2025

Performance/MapCompact is marked as safe but it should not be as the suggested refactoring is not equivalent

[true, false, nil].compact              #=> [true, false]
[true, false, nil].filter_map(&:itself) #=> [true]

This is confusing for new Ruby developers.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

=== Safety
This cop's autocorrection is unsafe because `map { ... }.compact` might yield
This cop is unsafe because `map { ... }.compact` might yield
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This docs/modules/ROOT/pages/cops_performance.adoc is auto-generated. Can you update the source code document instead? Also, no update to docs/modules/ROOT/pages/cops_performance.adoc is needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @koic, thanks for the review. I have updated the PR as requested. Cheers.

@koic koic merged commit d8cddb4 into rubocop:master May 23, 2025
15 checks passed
@koic
Copy link
Member

koic commented May 23, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants