Skip to content

Change ics url to an https:// #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Change ics url to an https:// #519

merged 2 commits into from
Sep 15, 2023

Conversation

adarsh
Copy link
Collaborator

@adarsh adarsh commented Sep 12, 2023

No description provided.

@adarsh
Copy link
Collaborator Author

adarsh commented Sep 12, 2023

Addresses #511 (comment)

Copy link
Collaborator

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -32,7 +32,7 @@ <h1><a class="extruded" href="/"><span>Ruby&nbsp;</span><span>Conferences</span>
<ul>
<li><a href="https://twitter.com/rubyconferences">@rubyconferences</a></li>
<li><a href="https://github.com/ruby-conferences/ruby-conferences.github.io">source</a></li>
<li><a href="http://www.rubyconferences.org/calendar.ics">ics calendar feed</a></li>
<li><a href="https://www.rubyconferences.org/calendar.ics">ics calendar feed</a></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adarsh I think what we want is https://rubyconferences.org/calendar.ics

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we actually ended up with the http:// URL because the https:// with www didn't work, see #517 (comment)

@adarsh adarsh merged commit dc28617 into master Sep 15, 2023
@adarsh adarsh deleted the ap-https branch September 15, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants