Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/meetup page filter #739

Merged
merged 5 commits into from
Aug 31, 2024
Merged

Feat/meetup page filter #739

merged 5 commits into from
Aug 31, 2024

Conversation

adriangohjw
Copy link
Contributor

closes #632

major change - adding a filter by YYYY-MM

  • Implemented a filter by year and month using raw JavaScript (no new dependencies).
  • Used an onclick method to show/hide relevant meetups.
  • Note: The UI isn't perfect, but it's a functional and quick fix.

other considerations

  • Didn't add a location filter:
    • It would require adding more data for each meetup, which is cumbersome.
    • Users likely go directly to meetup.com if searching by country/state. We can revisit this in a future PR if needed.

other minor UI improvements

  • Removed redundant "website" text to declutter the UI.

demo

Screen.Recording.2024-08-31.at.2.57.01.AM.mov

@marcoroth
Copy link
Collaborator

marcoroth commented Aug 31, 2024

This is awesome, thanks for the contribution @adriangohjw!

I think I only have two small things that could improve the UX a bit:

  • Increase the contrast for the text in the clips, they might be a bit hard to read right now.
  • Maybe wrap the clips below each other so you don't have to scroll, maybe a simple flex-wrap: wrap; does the trick.

Otherwise this looks good, looking forward to merge and deploy this! 🚀

@adriangohjw
Copy link
Contributor Author

@marcoroth good suggestions! changes made

image

Copy link
Collaborator

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you so much @adriangohjw!

@marcoroth marcoroth merged commit 84da7c8 into ruby-conferences:main Aug 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meetup Page improvement
2 participants