Unify behavior of default_error_status, ref #1177#1264
Open
namusyaka wants to merge 1 commit into
Open
Conversation
Member
|
If this change is to be merged we need an UPGRADING entry, a README doc update and CHANGELOG. I am very worried though. It would be the first thing that carries into what's being |
namusyaka
force-pushed
the
inherit-default_error_status
branch
from
1e793c1 to
fd31ae9
Compare
namusyaka
force-pushed
the
inherit-default_error_status
branch
from
fd31ae9 to
674c4f7
Compare
Contributor
Author
|
@dblock Force pushed. Yes, this is first step for providing that. |
Member
|
Thanks. Leaving this open for others to comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #1177
I think we should unify behavior of default_error_status before adding useful verbs.