Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subclasses initialize must call super #123

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Subclasses initialize must call super #123

merged 1 commit into from
Feb 14, 2025

Conversation

nobu
Copy link
Member

@nobu nobu commented Feb 14, 2025 •
edited
Loading

Warn wrong code, #100:

Some Ruby apps subclass Logger without running the superclass constructor, which means that @level_override isn't initialized properly.

@nobu
Subclasses initialize must call super
1efdf6b 
Warn wrong code, #100:
> Some Ruby apps subclass Logger without running the superclass
> constructor, which means that `@level_override` isn't initialized
> properly.
@nobu nobu merged commit 1efdf6b into master Feb 14, 2025
62 checks passed
@nobu nobu deleted the initialize-warning branch February 14, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nobu