Skip to content

Remove bundler enforcement on ruby 2.3 #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

bpinto
Copy link
Contributor

@bpinto bpinto commented Jan 26, 2021

The fix for rubygems/rubygems#3570 was released with bundler 2.2.0.rc.1.

The fix for rubygems/rubygems#3570 was released with bundler 2.2.0.rc.1.
@eregon
Copy link
Member

eregon commented Jan 26, 2021

Related: #128

I guess the reason for the change is you want to use Bundler 2 on Ruby 2.3?
Seems reasonable now that that bug is fixed, but I would not be too surprised if there are other issues with Bundler on Ruby 2.3.

You need to update the generated files as mentioned in CONTRIBUTING.md.

@bpinto bpinto force-pushed the remove-bundler-enforcement-on-ruby-2.3 branch from deed98b to 2657d32 Compare January 26, 2021 13:23
@bpinto
Copy link
Contributor Author

bpinto commented Jan 26, 2021

I guess the reason for the change is you want to use Bundler 2 on Ruby 2.3?

You are correct. 👍

You need to update the generated files as mentioned in CONTRIBUTING.md.

Sorry, I read that when I was creating the PR and after running npm run package I forgot to push the updated commit 😓

Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@eregon eregon merged commit a358e49 into ruby:master Jan 26, 2021
@eregon eregon mentioned this pull request Jan 26, 2021
@eregon
Copy link
Member

eregon commented Jan 26, 2021

@waltjones
Copy link

waltjones commented Jan 26, 2021

@bpinto @eregon Help look at #148?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants