Skip to content

Specs for type validation of writes to $@ #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Specs for type validation of writes to $@ #1261

wants to merge 2 commits into from

Conversation

herwinw
Copy link
Member

@herwinw herwinw commented May 8, 2025

No description provided.

andrykonchin
andrykonchin approved these changes May 8, 2025
View reviewed changes
@herwinw herwinw force-pushed the predefined_dollar_at branch 2 times, most recently from b16a93e to 6cc01c2 Compare May 20, 2025 07:37
herwinw added 2 commits May 20, 2025 09:38
@herwinw
Convert Exception#set_backtrace into a shared spec
aa2a355 
This can be reused to test assignment of $@
@herwinw
Specs for type validation of writes to $@
1c46ccd 
Use the shared specs for Exception#set_backtrace
@herwinw herwinw force-pushed the predefined_dollar_at branch from 6cc01c2 to 1c46ccd Compare May 20, 2025 07:38
andrykonchin
andrykonchin approved these changes May 20, 2025
View reviewed changes
Copy link
Member

@andrykonchin andrykonchin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

The only thing I've noticed is in:

-> *backtrace {
      # ...
      $@ = backtrace.first unless backtrace.empty?

the *backtrace parameter may not be a rest one (with *) - it seems it's not used anywhere and a single argument is always passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrykonchin andrykonchin andrykonchin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@herwinw @andrykonchin