lock rubocop versions and fix remaining violations

rubyatscale · May 6, 2024 · 8adb12a · 8adb12a
1 parent 6095653
commit 8adb12a
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 26 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -114,33 +114,27 @@ GEM
     git (1.19.1)
       addressable (~> 2.8)
       rchardet (~> 1.8)
-    i18n (1.14.4)
+    i18n (1.14.5)
       concurrent-ruby (~> 1.0)
     io-console (0.7.2)
     irb (1.13.1)
       rdoc (>= 4.0.0)
       reline (>= 0.4.2)
-    json (2.7.2)
     kramdown (2.4.0)
       rexml
     kramdown-parser-gfm (1.1.0)
       kramdown (~> 2.0)
-    language_server-protocol (3.17.0.3)
     loofah (2.22.0)
       crass (~> 1.0.2)
       nokogiri (>= 1.12.0)
     method_source (1.1.0)
-    mini_portile2 (2.8.6)
     minitest (5.22.3)
     mutex_m (0.2.0)
     nap (1.1.0)
     net-http (0.4.1)
       uri
     netrc (0.11.0)
     no_proxy_fix (0.1.2)
-    nokogiri (1.16.4)
-      mini_portile2 (~> 2.8.2)
-      racc (~> 1.4)
     nokogiri (1.16.4-aarch64-linux)
       racc (~> 1.4)
     nokogiri (1.16.4-arm64-darwin)
@@ -231,20 +225,18 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
     rspec-support (3.13.1)
-    rubocop (1.63.4)
-      json (~> 2.3)
-      language_server-protocol (>= 3.17.0)
+    rubocop (1.26.1)
       parallel (~> 1.10)
-      parser (>= 3.3.0.2)
+      parser (>= 3.1.0.0)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
-      rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.31.1, < 2.0)
+      rexml
+      rubocop-ast (>= 1.16.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 2.4.0, < 3.0)
+      unicode-display_width (>= 1.4.0, < 3.0)
     rubocop-ast (1.31.3)
       parser (>= 3.3.1.0)
-    rubocop-sorbet (0.8.3)
+    rubocop-sorbet (0.6.11)
       rubocop (>= 0.90.0)
     ruby-progressbar (1.13.0)
     sawyer (0.9.2)
@@ -303,7 +295,6 @@ GEM
 PLATFORMS
   aarch64-linux
   arm64-darwin
-  ruby
   universal-darwin
   x86_64-darwin
   x86_64-linux
@@ -316,8 +307,8 @@ DEPENDENCIES
   railties
   rake
   rspec (~> 3.0)
-  rubocop
-  rubocop-sorbet
+  rubocop (~> 1.26.0)
+  rubocop-sorbet (~> 0.6.0)
   sorbet
   tapioca
 

diff --git a/danger-packwerk.gemspec b/danger-packwerk.gemspec
@@ -40,8 +40,8 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'pry'
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'rspec', '~> 3.0'
-  spec.add_development_dependency 'rubocop'
-  spec.add_development_dependency 'rubocop-sorbet'
+  spec.add_development_dependency 'rubocop', '~> 1.26.0'
+  spec.add_development_dependency 'rubocop-sorbet', '~> 0.6.0'
   spec.add_development_dependency 'sorbet'
   spec.add_development_dependency 'tapioca'
 end
diff --git a/lib/danger-packwerk/danger_package_todo_yml_changes.rb b/lib/danger-packwerk/danger_package_todo_yml_changes.rb
@@ -20,9 +20,9 @@ class DangerPackageTodoYmlChanges < Danger::Plugin
     BeforeComment = T.type_alias { T.proc.params(violation_diff: ViolationDiff, changed_package_todo_ymls: T::Array[String]).void }
     DEFAULT_BEFORE_COMMENT = T.let(->(violation_diff, changed_package_todo_ymls) {}, BeforeComment)
     DEFAULT_VIOLATION_TYPES = T.let([
-                                      DEPENDENCY_VIOLATION_TYPE,
-                                      PRIVACY_VIOLATION_TYPE
-                                    ], T::Array[String])
+      DEPENDENCY_VIOLATION_TYPE,
+      PRIVACY_VIOLATION_TYPE
+    ].freeze, T::Array[String])
 
     sig do
       params(

diff --git a/lib/danger-packwerk/danger_packwerk.rb b/lib/danger-packwerk/danger_packwerk.rb
@@ -23,9 +23,9 @@ class DangerPackwerk < Danger::Plugin
     DEFAULT_FAIL = false
     DEFAULT_FAILURE_MESSAGE = 'Packwerk violations were detected! Please resolve them to unblock the build.'
     DEFAULT_VIOLATION_TYPES = T.let([
-                                      DEPENDENCY_VIOLATION_TYPE,
-                                      PRIVACY_VIOLATION_TYPE
-                                    ], T::Array[String])
+      DEPENDENCY_VIOLATION_TYPE,
+      PRIVACY_VIOLATION_TYPE
+    ].freeze, T::Array[String])
 
     class CommentGroupingStrategy < ::T::Enum
       enums do