Make the RubocopProtectionInterface simpler to support easier rubocop…

… based package protections (#10) * By default, a protection has no unmet preconditions * add cop name to the interface * move get_offenses_for_existing_violations into interface, fix tests * remove cop name constant * remove root package restriction * add back custom message for fail on any * move cop configs to rubocop interface * organize code into abstract vs overiddable * bump version * move namespace package protection interface into cop * move typed api protection interface into cop * rubocop * tc
rubyatscale · Jun 30, 2022 · 0280038 · 0280038
1 parent 0c312f7
commit 0280038
Show file tree

Hide file tree

Showing 10 changed files with 238 additions and 265 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    package_protections (1.0.0)
+    package_protections (1.1.0)
       activesupport
       parse_packwerk
       rubocop
@@ -23,9 +23,9 @@ GEM
     i18n (1.10.0)
       concurrent-ruby (~> 1.0)
     method_source (1.0.0)
-    minitest (5.15.0)
+    minitest (5.16.1)
     parallel (1.21.0)
-    parse_packwerk (0.10.0)
+    parse_packwerk (0.10.1)
       sorbet-runtime
     parser (3.1.0.0)
       ast (~> 2.4.1)
@@ -67,7 +67,7 @@ GEM
       parser (>= 3.0.1.1)
     rubocop-rspec (2.8.0)
       rubocop (~> 1.19)
-    rubocop-sorbet (0.6.8)
+    rubocop-sorbet (0.6.10)
       rubocop (>= 0.90.0)
     ruby-progressbar (1.11.0)
     sorbet (0.5.9588)

diff --git a/lib/package_protections/private.rb b/lib/package_protections/private.rb
@@ -3,11 +3,9 @@
 
 require 'package_protections/private/colorized_string'
 require 'package_protections/private/output'
-require 'package_protections/private/typed_api_protection'
 require 'package_protections/private/incoming_privacy_protection'
 require 'package_protections/private/outgoing_dependency_protection'
 require 'package_protections/private/metadata_modifiers'
-require 'package_protections/private/multiple_namespaces_protection'
 require 'package_protections/private/visibility_protection'
 require 'package_protections/private/configuration'
 

diff --git a/lib/package_protections/private/configuration.rb b/lib/package_protections/private/configuration.rb
@@ -28,8 +28,8 @@ def default_protections
         [
           Private::OutgoingDependencyProtection.new,
           Private::IncomingPrivacyProtection.new,
-          Private::TypedApiProtection.new,
-          Private::MultipleNamespacesProtection.new,
+          RuboCop::Cop::PackageProtections::TypedPublicApi.new,
+          RuboCop::Cop::PackageProtections::NamespacedUnderPackageName.new,
           Private::VisibilityProtection.new
         ]
       end

diff --git a/lib/package_protections/private/multiple_namespaces_protection.rb b/lib/package_protections/private/multiple_namespaces_protection.rb
diff --git a/lib/package_protections/private/typed_api_protection.rb b/lib/package_protections/private/typed_api_protection.rb