tests for check-unused-dependencies

rubyatscale · Aug 21, 2024 · 9c3204a · 9c3204a
1 parent 6181e8d
commit 9c3204a
Showing 1 changed file with 25 additions and 8 deletions.
diff --git a/tests/check_unnecessary_dependencies.rs b/tests/check_unnecessary_dependencies.rs
@@ -3,13 +3,12 @@ use predicates::prelude::*;
 use std::{error::Error, fs, process::Command};
 mod common;
 
-#[test]
-fn test_check_unnecessary_dependencies() -> Result<(), Box<dyn Error>> {
+fn assert_check_unused_dependencies(cmd: &str) -> Result<(), Box<dyn Error>> {
     Command::cargo_bin("pks")?
         .arg("--project-root")
         .arg("tests/fixtures/app_with_dependency_cycles")
         .arg("--debug")
-        .arg("check-unnecessary-dependencies")
+        .arg(&cmd)
         .assert()
         .failure()
         .stdout(predicate::str::contains(
@@ -19,19 +18,29 @@ fn test_check_unnecessary_dependencies() -> Result<(), Box<dyn Error>> {
             "packs/foo depends on packs/bar but does not use it",
         ))
         .stderr(predicate::str::contains(
-           "Error: Found 3 unnecessary dependencies. Run command with `--auto-correct` to remove them.",
+           format!("Error: Found 3 unnecessary dependencies. Run `packs {}| --auto-correct` to remove them.", &cmd),
         ));
     Ok(())
 }
 
 #[test]
-fn test_auto_correct_unnecessary_dependencies() -> Result<(), Box<dyn Error>> {
+fn test_check_unnecessary_dependencies() -> Result<(), Box<dyn Error>> {
+    assert_check_unused_dependencies("check-unnecessary-dependencies")
+}
+
+#[test]
+fn test_check_unused_dependencies() -> Result<(), Box<dyn Error>> {
+    assert_check_unused_dependencies("check-unused-dependencies")
+}
+
+
+fn assert_auto_correct_unused_dependencies(cmd: &str, flag: &str) -> Result<(), Box<dyn Error>> {
     Command::cargo_bin("pks")?
         .arg("--project-root")
         .arg("tests/fixtures/app_with_unnecessary_dependencies")
         .arg("--debug")
-        .arg("check-unnecessary-dependencies")
-        .arg("--auto-correct")
+        .arg(&cmd)
+        .arg(&flag)
         .assert()
         .success();
 
@@ -49,14 +58,22 @@ fn test_auto_correct_unnecessary_dependencies() -> Result<(), Box<dyn Error>> {
     Ok(())
 }
 
+#[test]
+fn test_auto_correct_unnecessary_dependencies() -> Result<(), Box<dyn Error>> {
+    assert_auto_correct_unused_dependencies("check-unused-dependencies", "--auto-correct")?;
+    assert_auto_correct_unused_dependencies("check-unused-dependencies", "-a")?;
+    assert_auto_correct_unused_dependencies("check-unnecessary-dependencies", "-a")?;
+    assert_auto_correct_unused_dependencies("check-unnecessary-dependencies", "--auto-correct")
+}
+
 #[test]
 fn test_check_unnecessary_dependencies_no_issue() -> Result<(), Box<dyn Error>>
 {
     Command::cargo_bin("pks")?
         .arg("--project-root")
         .arg("tests/fixtures/simple_app")
         .arg("--debug")
-        .arg("check-unnecessary-dependencies")
+        .arg("check-unused-dependencies")
         .assert()
         .success();
     Ok(())