Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep necessary quotes around private constants #14

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Keep necessary quotes around private constants #14

merged 2 commits into from
Oct 29, 2024

Conversation

perryqh
Copy link
Contributor

@perryqh perryqh commented Oct 29, 2024 •
edited
Loading

pks uses the serde_yml crate to de/serialize yml.

This isn't a problem unless the constant begins with ::.

This PR adds the quotes back after yml serialization.

ignored_private_constants:
- "::Quotes::Are::Required"
- "Not::Required"

In the above example, this PR will keep the quotes for "::Quotes::Are::Required", but continue to strip them off for Not::Required

@perryqh perryqh merged commit 11c8648 into main Oct 29, 2024
9 checks passed
@perryqh perryqh deleted the ph/keep-necessary-quotes-in-private-constants branch October 29, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstannard tstannard tstannard approved these changes

@ashleywillard ashleywillard Awaiting requested review from ashleywillard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@perryqh @tstannard