New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't stringify numeric keys in JS Maps #337

Merged

SamSaffron merged 1 commit into rubyjs:main from bnoordhuis:numeric-map-keys

Jan 19, 2025

Collaborator

bnoordhuis commented Jan 18, 2025 •

edited

Loading

~~First commit is #336, to be rebased away when that PR lands.~~ - edit: rebased

Collaborator Author

bnoordhuis commented Jan 19, 2025

Suspected flake on linux-amd64 - ruby-3.2 - gnu, rerunning just in case:


free(): corrupted unsorted chunks
........S.......S.......F.S...................................................................

Finished in 3.256550s, 28.8649 runs/s, 47.5964 assertions/s.

  1) Failure:
MiniRacerTest#test_forking [test/mini_racer_test.rb:1042]:
forking test failed

Fork-and-continue is inherently risky so I'm inclined to think that's the cause, not a change in this PR.


          Don't stringify numeric keys in JS Maps

05abba0

bnoordhuis force-pushed the numeric-map-keys branch from a37dfdc to 05abba0 Compare

January 19, 2025 22:01

SamSaffron merged commit ffcbaf9 into rubyjs:main

22 of 25 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet