Update to V8 12.9 #342
Merged
Update to V8 12.9 #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes context.idle_notification because the V8 API it uses has been removed with no real replacement. V8 suggests to use Isolate::MemoryPressureNotification() instead but that's not really the same thing and overlaps significantly with context.low_memory_notification. Remove the stale object marshalling section from the README.
tisba
reviewed
Feb 4, 2025
| @@ -19,7 +19,7 @@ | |||
| $CXXFLAGS += " -g" unless $CXXFLAGS.split.include? "-g" | |||
| $CXXFLAGS += " -rdynamic" unless $CXXFLAGS.split.include? "-rdynamic" | |||
| $CXXFLAGS += " -fPIC" unless $CXXFLAGS.split.include? "-rdynamic" or IS_DARWIN | |||
| $CXXFLAGS += " -std=c++17" | |||
| $CXXFLAGS += " -std=c++20" | |||
There was a problem hiding this comment.
Do we need to update the README for compiler requirements too? https://github.com/rubyjs/mini_racer?tab=readme-ov-file#installation
There was a problem hiding this comment.
Good point, those are way out of date. Updated with the compiler recommendations from node's BUILDING.md
|
any ideas why all the tests are failing? I think it is struggling with bundle for some reason. |
You can do libv8-node releases now, right? If you make one, I'll restart CI and things should - fingers crossed - be green. |
|
Will do tomorrow
…On Wed, 5 Feb 2025 at 5:48 pm, Ben Noordhuis ***@***.***> wrote:
@SamSaffron <https://github.com/SamSaffron>
Could not find gem 'libv8-node (~> 23.6.1.0)', which is required by gem
You can do libv8-node releases now, right? If you make one, I'll restart
CI and things should - fingers crossed - be green.
—
Reply to this email directly, view it on GitHub
<#342 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAABIXLBXVQEQ2VXDJZW7332OGX3HAVCNFSM6AAAAABWPMGIV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZVHAZTEMJZGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes context.idle_notification because the V8 API it uses has been removed with no real replacement.
V8 suggests to use Isolate::MemoryPressureNotification() instead but that's not really the same thing and overlaps significantly with context.low_memory_notification.
Remove the stale object marshalling section from the README.
Needs a libv8-node release from its node-23 branch first