-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update project dependencies #360
chore: update project dependencies #360
Conversation
It is required by the different modules
…r nx packages to the latest version
…address various issues This will remove the ip package and address snyk and npm security issues
…kage to address various issues" This reverts commit 31ff650.
…address various issues This will remove the ip package and address snyk and npm security issues
This is necessary to fix the build issue in Android and iOS
It is required to check the circular dependencies
…age" This reverts commit a3acf1d.
…heck Required to solve the requirejs related npm security issue.
…onventional-changelog-for-jira in package.json
….1 in .nvmrc file
…ues caused due to node bump
Also update the ruby-version to 3.3.2
…it-raw-commit This is required to fix the nx affected command whcih generates the changelog
NX added that. I can remove it, but it'll be added again in the next update. From the past couple of iterations, I'm manually removing this. But this time I allowed it. Do you still propose to remove it @saikumarrs? |
…ress the medium level vulnerabilities
Are you sure it is Nx that added it? It is not supposed to make any changes to the code directly. Maybe it is something else. |
Yes, I ran this nx command to create a new sample app (I've mentioned the reason in the PR description) |
Yeah, please remove it as it is against our lint rules. |
|
Description of the change
react-native
package from0.73.2
to0.74.1
.nx
have also been to the newest versions.- Updated the Cocoapod version to
1.5.2
intest.yml
. This was needed to solve issues with the GitHub Action.- Removed
npm run check:circular
step frombuild-and-quality-checks.yml
. I'll explain more details about this later.- Replace the
Setup CocoaPods
step with this action: https://github.com/NiftyStack/install-cocoapods-action and also bump the ruby version to3.3.2
.- Removed
ip
package. This was also flagged by the npm security check.- Removed
inflight
package.- Update the
ws
to required version which doesn't contain any issues.20.0.0
20.15.1
in the .nvmrc file.nx
the Android and iOS sample apps were not building properly. To resolve that, we had to create a new sample app.- For example,
flipper
libraries have been removed, which is being used by the sample apps.- Most of the changes in the sample app are due to creating new apps.
A few of the tweaks done previously in the Podfile (sample iOS app) e.g., related to the
flipper
are no longer required. Those tweaks are either removed or commented out (this should be removed in future iterations).- Removed the
check:circular
script and the correspondingmadge
package. Actually,madge
had a transitive dependency on therequirejs
, which has been flagged by the npm security check. Therefore, we had to remove this for now.- Removed
storybook
from the devDependencies section, as it contained some flagged dependencies. This package was added earlier by nx and now it doesn't seem to be needed.- Added overrides for various packages:
micromatch
,@nx/devkit
,svgo
,glob
,tempfile
,rimraf
,data-urls
andjsdom
. I'll explain more details about these changes later.- Removed stale overrides.
nx
updated the various packages to a newer version, we got a bunch of deprecated packages and also one package (i.e.,requirejs
) was flagged by the npm security check. We solved most of such issues except a few deprecated ones which are used as a transitive dependency and we don't have any way to replace them on our own. Such dependencies should be removed in future. So when we perform a similar upgrade again in the future this should be resolved.20.15.1
, more packages were flagged by the npm security check, so we fixed all of them:- trim-newlines: https://www.npmjs.com/package/trim-newlines?activeTab=versions
- semver-regex: GHSA-44c6-4v22-4mhx
- lodash.template: GHSA-35jh-r3h4-6jhm (need to override the
git-raw-commits
)- http-cache-semantics: GHSA-rc47-6667-2j5j
- dot-prop: GHSA-ff7x-qrg7-qggm
NOTE: This PR change will not require any release.
Type of change
Related issues
Checklists
Development
Code review