Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: airship mapping and iterable device reg #4010

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

vinayteki95
Copy link
Contributor

What are the changes introduced in this PR?

  • Airship Mapping fix for group call
  • Iterable fix for missing device registration

What is the related Linear task?

Resolves INT-XXX

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@vinayteki95 vinayteki95 added DO NOT MERGE Don't merge this PR without having discussion DO NOT UPDATE DO NOT TOUCH labels Jan 23, 2025
@vinayteki95 vinayteki95 requested review from a team and sivashanmukh as code owners January 23, 2025 12:41
@vinayteki95 vinayteki95 changed the title Fix.airship mapping and iterable device reg fix.airship mapping and iterable device reg Jan 23, 2025
@vinayteki95 vinayteki95 changed the title fix.airship mapping and iterable device reg fix: airship mapping and iterable device reg Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.83%. Comparing base (ba8ad19) to head (d7ce2be).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4010      +/-   ##
===========================================
+ Coverage    90.78%   90.83%   +0.04%     
===========================================
  Files          624      624              
  Lines        32553    32597      +44     
  Branches      7727     7732       +5     
===========================================
+ Hits         29552    29608      +56     
+ Misses        2777     2734      -43     
- Partials       224      255      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Don't merge this PR without having discussion DO NOT TOUCH DO NOT UPDATE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants