-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: zoho record processing #4054
base: develop
Are you sure you want to change the base?
Conversation
Allure Test reports for this run are available at: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4054 +/- ##
===========================================
+ Coverage 91.04% 91.13% +0.08%
===========================================
Files 629 629
Lines 32841 32841
Branches 7792 7789 -3
===========================================
+ Hits 29901 29930 +29
+ Misses 2689 2663 -26
+ Partials 251 248 -3 ☔ View full report in Codecov by Sentry. |
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
|
What are the changes introduced in this PR?
Refactor Zoho to remove assumptions related to all events that will have the same action. This makes transformer code independent and fault-tolerant if rudder server or source behaves differently.
What is the related Linear task?
Resolves INT-3239
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.