-
-
Notifications
You must be signed in to change notification settings - Fork 923
tests: Add visual/define_bits_jpeg2 test #21738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kjarosh
wants to merge
1
commit into
ruffle-rs:master
Choose a base branch
from
kjarosh:define-bits-test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+54
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+567 Bytes
tests/tests/swfs/visual/define_bits_jpeg2/11_image_low_quality.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
This test verifies various images embedded into a SWF. | ||
If you need to add more images, it's better to copy this test than to extend it. | ||
|
||
List of images: | ||
|
||
* `01_image.gif` – standard GIF, | ||
* `02_image_i.gif` – GIF with interlacing, | ||
* `03_image_420.jpeg` – JPEG with 4:2:0 chroma subsampling, | ||
* `04_image_422.jpeg` – JPEG with 4:2:2 chroma subsampling, | ||
* `05_image_440.jpeg` – JPEG with 4:4:0 chroma subsampling, | ||
* `06_image_444.jpeg` – JPEG with 4:4:4 chroma subsampling, | ||
* `07_image_ac.jpeg` – JPEG with arithmetic coding, | ||
* `08_image_cmyk.jpeg` – JPEG with CMYK color coding, | ||
* `09_image_fi.jpeg` – JPEG with Fast Integer DCT, | ||
* `10_image_fp.jpeg` – JPEG with Floating-Point DCT, | ||
* `11_image_low_quality.jpeg` – JPEG with low quality, | ||
* `12_image_meta.jpeg` – JPEG with additional metadata, | ||
* `13_image_np.jpeg` – non-progressive JPEG, | ||
* `14_image_rm8.jpeg` – JPEG with restart markers, 8 MCU rows, | ||
* `15_image_rm16.jpeg` – JPEG with restart markers, 16 MCU rows, | ||
* `16_image_rm32.jpeg` – JPEG with restart markers, 32 MCU rows, | ||
* `17_image_8gray.png` – 8-bit gray PNG, | ||
* `18_image_8graya.png` – 8-bit gray PNG with alpha, | ||
* `19_image_8rgb.png` – 8-bit RGB PNG, | ||
* `20_image_8rgba.png` – 8-bit RGB PNG with alpha, | ||
* `21_image_16gray.png` – 16-bit gray PNG, | ||
* `22_image_16graya.png` – 16-bit gray PNG with alpha, | ||
* `23_image_16rgb.png` – 16-bit RGB PNG, | ||
* `24_image_16rgba.png` – 16-bit RGB PNG with alpha, | ||
* `25_image_adam7.png` – PNG with interlacing, | ||
* `26_image_c0.png` – PNG with compression level 0, | ||
* `27_image_c5.png` – PNG with compression level 5, | ||
* `28_image_c9.png` – PNG with compression level 9, | ||
* `29_image_meta.png` – PNG with additional metadata. | ||
|
||
Images are embedded sequentially. |
Oops, something went wrong.
Oops, something went wrong.
Empty file.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
num_ticks = 1 | ||
|
||
# FIXME We're badly decoding JPEG images with 4:2:0 and 4:4:0 chroma subsampling | ||
|
||
[[image_comparisons.output.checks]] | ||
tolerance = 0 | ||
max_outliers = 1500 | ||
|
||
[[image_comparisons.output.checks]] | ||
tolerance = 24 | ||
max_outliers = 50 | ||
|
||
[[image_comparisons.output.checks]] | ||
tolerance = 64 | ||
max_outliers = 0 | ||
|
||
[player_options] | ||
with_renderer = { optional = false, sample_count = 4 } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the test pattern was rotated by 90 degrees, perhaps some other subsampling options would (also) look wrong!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always those chroma sample locations...
https://www.pcmag.com/encyclopedia/term/chroma-subsampling
https://www.sciencedirect.com/topics/engineering/chroma-sample
Notice how there is a difference of horizontal and vertical chroma sample offsets in the different modes.
What I'm also saying is - if the test pattern was magnified just 2x (with nearest interpolation, or even recreated with two-pixel tall gradients) - it would probably look a lot less wrong, even if there's technically a mismatch. And not a lot of real world content is like these images.