avm2: Fix edge cases in Math.pow #21933
Merged
+25
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
A-avm2
Dinnerbone
approved these changes
Oct 15, 2025
Co-authored-by: jarca0123 <[email protected]>
Instead of going through all checks, if n and p are finite, Math.pow goes straight into executing regular powf. This is the most common case of calling Math.pow.
Lord-McSweeney
force-pushed
the
math-pow
branch
from
7781844 to
916ca2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains the last unmerged part of #21018
I added a fast path for finite n and p so that those special cases do not have that much effect on performance.