-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 24 #28
Merged
+877
−23
Merged
Issue 24 #28
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4861c2c
run-as-root/magento2-prometheus-exporter#24:
swnsma fc06fbe
run-as-root/magento2-prometheus-exporter#24:
swnsma 44b753a
run-as-root/magento2-prometheus-exporter#24:
swnsma fbcbf53
run-as-root/magento2-prometheus-exporter#24:
swnsma 9cc87e9
run-as-root/magento2-prometheus-exporter#24:
swnsma fe5d572
run-as-root/magento2-prometheus-exporter#24:
swnsma c360002
run-as-root/magento2-prometheus-exporter#24:
swnsma e6ae0ef
run-as-root/magento2-prometheus-exporter#24:
swnsma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
275 changes: 275 additions & 0 deletions
275
Test/Unit/Aggregator/Category/CategoryCountAggregatorTest.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,275 @@ | ||
| <?php declare(strict_types=1); | ||
|
|
||
| namespace RunAsRoot\PrometheusExporter\Test\Unit\Aggregator\Shipment; | ||
|
|
||
| use Magento\Catalog\Api\Data\CategoryInterface; | ||
| use Magento\Framework\App\ResourceConnection; | ||
| use Magento\Framework\DB\Adapter\AdapterInterface; | ||
| use Magento\Framework\DB\Select; | ||
| use Magento\Framework\DB\Sql\Expression; | ||
| use Magento\Framework\DB\Sql\ExpressionFactory; | ||
| use Magento\Framework\EntityManager\EntityMetadataInterface; | ||
| use Magento\Framework\EntityManager\MetadataPool; | ||
| use PHPUnit\Framework\MockObject\MockObject; | ||
| use PHPUnit\Framework\TestCase; | ||
| use RunAsRoot\PrometheusExporter\Aggregator\Category\CategoryCountAggregator; | ||
| use RunAsRoot\PrometheusExporter\Service\UpdateMetricService; | ||
|
|
||
| final class CategoryCountAggregatorTest extends TestCase | ||
| { | ||
| private const METRIC_CODE = 'magento_catalog_category_count_total'; | ||
| private const T_ATT = 'm2_eav_attribute'; | ||
| private const T_CAT_ENT_INT = 'm2_catalog_category_entity_int'; | ||
| private const T_CAT_ENT = 'm2_catalog_category_entity'; | ||
| private const T_STORE_GROUP = 'm2_store_group'; | ||
| private const T_STORE = 'm2_store'; | ||
| private const LINK_FIELD = 'row_id'; | ||
| private const ATTR_ID = 77; | ||
|
|
||
| private CategoryCountAggregator $subject; | ||
|
|
||
| /** @var MockObject|UpdateMetricService */ | ||
| private $updateMetricService; | ||
|
|
||
| /** @var MockObject|ResourceConnection */ | ||
| private $resourceConnection; | ||
|
|
||
| /** @var MockObject|ExpressionFactory */ | ||
| private $expressionFactory; | ||
|
|
||
| /** @var MockObject|MetadataPool */ | ||
| private $metadataPool; | ||
|
|
||
| protected function setUp(): void | ||
| { | ||
| $this->updateMetricService = $this->createMock(UpdateMetricService::class); | ||
| $this->resourceConnection = $this->createMock(ResourceConnection::class); | ||
| $this->expressionFactory = $this->createMock(ExpressionFactory::class); | ||
| $this->metadataPool = $this->createMock(MetadataPool::class); | ||
|
|
||
| $this->subject = new CategoryCountAggregator( | ||
| $this->updateMetricService, | ||
| $this->resourceConnection, | ||
| $this->metadataPool, | ||
| $this->expressionFactory | ||
| ); | ||
| } | ||
|
|
||
| private function getStatisticData(): array | ||
| { | ||
| return [ | ||
| [ | ||
| 'STORE_CODE' => 'default', | ||
| 'ACTIVE_IN_MENU' => 50, | ||
| 'ACTIVE_NOT_IN_MENU' => 10, | ||
| 'NOT_ACTIVE_IN_MENU' => 25, | ||
| 'NOT_ACTIVE_NOT_IN_MENU' => 15 | ||
|
|
||
| ], | ||
| [ | ||
| 'STORE_CODE' => 'base', | ||
| 'ACTIVE_IN_MENU' => 18, | ||
| 'ACTIVE_NOT_IN_MENU' => 3, | ||
| 'NOT_ACTIVE_IN_MENU' => 4, | ||
| 'NOT_ACTIVE_NOT_IN_MENU' => 1 | ||
|
|
||
| ], | ||
| [ | ||
| 'STORE_CODE' => 'eu', | ||
| 'ACTIVE_IN_MENU' => 79, | ||
| 'ACTIVE_NOT_IN_MENU' => 21, | ||
| 'NOT_ACTIVE_IN_MENU' => 15, | ||
| 'NOT_ACTIVE_NOT_IN_MENU' => 16 | ||
|
|
||
| ], | ||
| ]; | ||
| } | ||
|
|
||
| private function getSelectMock(): MockObject | ||
| { | ||
| $select = $this->createMock(Select::class); | ||
|
|
||
| $select->expects($this->exactly(3))->method('from') | ||
| ->withConsecutive([self::T_ATT], [self::T_ATT], [["sg" => self::T_STORE_GROUP]])->willReturn($select); | ||
|
|
||
| $select->expects($this->exactly(4))->method('where') | ||
| ->withConsecutive( | ||
| ['entity_type_id = ?', 3], | ||
| ['attribute_code = ?', 'is_active'], | ||
| ['entity_type_id = ?', 3], | ||
| ['attribute_code = ?', 'include_in_menu'], | ||
| )->willReturn($select); | ||
| $select->expects($this->exactly(3)) | ||
| ->method('reset') | ||
| ->with(Select::COLUMNS) | ||
| ->willReturn($select); | ||
|
|
||
| $select->expects($this->exactly(3))->method('joinInner') | ||
| ->withConsecutive( | ||
| [ | ||
| ['s' => self::T_STORE], | ||
| 'sg.group_id = s.group_id' | ||
| ], | ||
| [ | ||
| ['cce1' => self::T_CAT_ENT], | ||
| 'sg.root_category_id = cce1.entity_id' | ||
| ], | ||
| [ | ||
| ['cce2' => self::T_CAT_ENT], | ||
| "cce2.path like CONCAT(cce1.path, '%')" | ||
| ] | ||
| )->willReturn($select); | ||
|
|
||
| $select->expects($this->exactly(4))->method('joinLeft') | ||
| ->withConsecutive( | ||
| [ | ||
| ['ccei1' => self::T_CAT_ENT_INT], | ||
| sprintf( | ||
| "cce2.%s = ccei1.%s AND ccei1.attribute_id = %s AND ccei1.store_id = s.store_id", | ||
| self::LINK_FIELD, | ||
| self::LINK_FIELD, | ||
| self::ATTR_ID | ||
| ) | ||
| ], | ||
| [ | ||
| ['ccei2' => self::T_CAT_ENT_INT], | ||
| sprintf( | ||
| "cce2.%s = ccei2.%s AND ccei2.attribute_id = %s AND ccei2.store_id = 0", | ||
| self::LINK_FIELD, | ||
| self::LINK_FIELD, | ||
| self::ATTR_ID | ||
| ) | ||
| ], | ||
| [ | ||
| ['ccei3' => self::T_CAT_ENT_INT], | ||
| sprintf( | ||
| "cce2.%s = ccei3.%s AND ccei3.attribute_id = %s AND ccei3.store_id = s.store_id", | ||
| self::LINK_FIELD, | ||
| self::LINK_FIELD, | ||
| self::ATTR_ID | ||
| ) | ||
| ], | ||
| [ | ||
| ['ccei4' => self::T_CAT_ENT_INT], | ||
| sprintf( | ||
| "cce2.%s = ccei4.%s AND ccei4.attribute_id = %s AND ccei4.store_id = 0", | ||
| self::LINK_FIELD, | ||
| self::LINK_FIELD, | ||
| self::ATTR_ID | ||
| ) | ||
| ] | ||
| )->willReturn($select); | ||
|
|
||
| $expressionMock = $this->createMock(Expression::class); | ||
| $this->expressionFactory->expects($this->exactly(4)) | ||
| ->method('create') | ||
| ->willReturnMap($this->getExpressionsMap($expressionMock)); | ||
| $select->expects($this->exactly(3))->method('columns') | ||
| ->withConsecutive( | ||
| [ | ||
| ['attribute_id'] | ||
| ], | ||
| [ | ||
| ['attribute_id'] | ||
| ], | ||
| [ | ||
| [ | ||
| 'STORE_CODE' => 's.code', | ||
| 'ACTIVE_IN_MENU' => $expressionMock, | ||
| 'ACTIVE_NOT_IN_MENU' => $expressionMock, | ||
| 'NOT_ACTIVE_IN_MENU' => $expressionMock, | ||
| 'NOT_ACTIVE_NOT_IN_MENU' => $expressionMock | ||
| ] | ||
| ] | ||
| )->willReturn($select); | ||
|
|
||
| $select->expects($this->once())->method('group')->with('s.code'); | ||
|
|
||
| return $select; | ||
| } | ||
|
|
||
| private function getExpressionsMap(Expression $expressionMock): array | ||
| { | ||
| $expression = 'COUNT(( | ||
| %s IF(ccei1.value IS NULL, ccei2.value, ccei1.value) AND | ||
| %s IF(ccei3.value IS NULL, ccei4.value, ccei3.value) | ||
| ) or null)'; | ||
|
|
||
| return [ | ||
| [['expression' => sprintf($expression, '', '')], $expressionMock], | ||
| [['expression' => sprintf($expression, '', 'NOT')], $expressionMock], | ||
| [['expression' => sprintf($expression, 'NOT', '')], $expressionMock], | ||
| [['expression' => sprintf($expression, 'NOT', 'NOT')], $expressionMock], | ||
| ]; | ||
| } | ||
|
|
||
| private function getTableNamesMap(): array | ||
| { | ||
| return [ | ||
| ['eav_attribute', self::T_ATT], | ||
| ['catalog_category_entity_int', self::T_CAT_ENT_INT], | ||
| ['catalog_category_entity', self::T_CAT_ENT], | ||
| ['store', self::T_STORE], | ||
| ['store_group', self::T_STORE_GROUP], | ||
| ]; | ||
| } | ||
|
|
||
| public function testAggregate(): void | ||
| { | ||
| $connection = $this->createMock(AdapterInterface::class); | ||
| $statisticData = $this->getStatisticData(); | ||
| $this->resourceConnection->expects($this->once())->method('getConnection')->willReturn($connection); | ||
| $connection->expects($this->exactly(10)) | ||
| ->method('getTableName') | ||
| ->willReturnMap($this->getTableNamesMap()); | ||
| $entityMetadata = $this->createMock(EntityMetadataInterface::class); | ||
| $entityMetadata->expects($this->once())->method('getLinkField')->willReturn(self::LINK_FIELD); | ||
| $this->metadataPool->expects($this->once())->method('getMetadata') | ||
| ->with(CategoryInterface::class)->willReturn($entityMetadata); | ||
|
|
||
| $select = $this->getSelectMock(); | ||
| $connection->expects($this->exactly(3))->method('select')->willReturn($select); | ||
| $connection->expects($this->exactly(2))->method('fetchOne')->willReturn(self::ATTR_ID); | ||
| $connection->expects($this->once()) | ||
| ->method('fetchAll') | ||
| ->with($select) | ||
| ->willReturn($statisticData); | ||
|
|
||
| $this->updateMetricService->expects($this->exactly(4 * count($statisticData))) | ||
| ->method('update') | ||
| ->withConsecutive(...$this->getUpdateMetricsArguments($statisticData)); | ||
|
|
||
| $this->subject->aggregate(); | ||
| } | ||
|
|
||
| private function getUpdateMetricsArguments(array $statisticData): array | ||
| { | ||
| $arguments = []; | ||
|
|
||
| foreach ($statisticData as $datum) { | ||
| $label = ['store_code' => $datum['STORE_CODE']]; | ||
| $arguments[] = [ | ||
| self::METRIC_CODE, | ||
| $datum['ACTIVE_IN_MENU'], | ||
| array_merge(['status' => 'enabled', 'menu_status' => 'enabled'], $label) | ||
| ]; | ||
| $arguments[] = [ | ||
| self::METRIC_CODE, | ||
| $datum['ACTIVE_NOT_IN_MENU'], | ||
| array_merge(['status' => 'enabled', 'menu_status' => 'disabled'], $label) | ||
| ]; | ||
| $arguments[] = [ | ||
| self::METRIC_CODE, | ||
| $datum['NOT_ACTIVE_IN_MENU'], | ||
| array_merge(['status' => 'disabled', 'menu_status' => 'enabled'], $label) | ||
| ]; | ||
| $arguments[] = [ | ||
| self::METRIC_CODE, | ||
| $datum['NOT_ACTIVE_NOT_IN_MENU'], | ||
| array_merge(['status' => 'disabled', 'menu_status' => 'disabled'], $label) | ||
| ]; | ||
| } | ||
|
|
||
| return $arguments; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are these abbreviations? Test? Table? I'd suggest to be more explicit here.