feat(cancel): ability to suppress atlantis cancel comments when --hide-unchanged-plan-comments is set#6472
Draft
ramonvermeulen wants to merge 1 commit into
Conversation
ramonvermeulen
force-pushed
the
f/suppress-cancelation-comments
branch
from
808be33 to
0806404
Compare
…hide-unchanged-plan-comments` is set Signed-off-by: Ramon Vermeulen <ramonvermeulen98@gmail.com>
ramonvermeulen
force-pushed
the
f/suppress-cancelation-comments
branch
from
0806404 to
23a58fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
Feature to suppress "noop" plan errors when
--hide-unchanged-plan-commentsevaluatestrue, this is requested as additional feature by @Wirone on top ofatlantis cancel(see #6215 (comment)).why
When running a large amount of plans it can be quite annoying if the PR gets spammed with all the
atlantis cancelerrors.Some other ideas to solve this problem could be to add a
Suppressproperty to theProjectCommandOutputthat can be filled based on the flag.tests
Added an unit test covering this scenario, will do manual testing later and update this PR.
references
#6215 (comment)