Upstream specifications from Kontrol test-suite #2244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 9, 2024
Enable generating KEVM claims from the basic blocks of Kontrol KCFGs
runtimeverification/kontrol#262
Merged
ehildenb
force-pushed
the
kontrol-specs
branch
2 times, most recently
from
174d466 to
c5a5f2b
Compare
…5s, > 0.25 faster)
ehildenb
force-pushed
the
kontrol-specs
branch
from
c5a5f2b to
2e7052c
Compare
nwatson22
reviewed
Feb 9, 2024
nwatson22
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on: #2241Blocked on: #2242Blocked on: #2243I generated a bunch of specifications from the Kontrol test-suite. In particular, after executing the entire test-suite, the basic blocks of each generated KCFG was turned into a KEVM claim. There were >2200 claims generated this way.
Of these claims, I graphed them: number of steps taken vs total time in backend execution. I did a linear regression of this data, and plotted that too (see attached image). The blue dots are the original tests, the orange dots are the expected time given the linear regression, and the green dots are the ones that are >2.5X standard deviations greater time than linear regression fit, showing that there are some proofs uncharacteristically slow.
I also compared the performance of these proofs against the old backend, and selected the ones that took >15s on the booster (to reduce noisiness), and that also were not more than 4X faster than the old backend. These proofs are included here in this PR as test-data for the backend team.