Update kmir run to behave more like cargo run
#524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jberthold
reviewed
Apr 10, 2025
jberthold
reviewed
Apr 10, 2025
kmir/src/kmir/__main__.py
Outdated
Comment on lines
86
to
87
| target = opts.bin if opts.bin else cargo.default_target | ||
| smir_file = cargo.smir_for(target) |
There was a problem hiding this comment.
This is where the --file option would be implemented: if given, smir_file is taken from there instead of asking cargo`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CargoProjectclass which can be used to gather information about a cargo project.kmir runnow usesCargoProjectwhich finds the.smir.jsonartifact in the target directory after invokingcargo build.Note that currently either
RUSTCwill need to be set to thestable-mir-jsoninstall, or the smir json files should already have been built that way and exist in the target directory. Later, we can get rid of this requirement when we packagestable-mir-jsonwithkmir.