Skip to content

Commit

Permalink
Merge pull request #54 from runwaylab/deployment-id-fixes
Browse files Browse the repository at this point in the history
Deployment id fixes
  • Loading branch information
GrantBirki authored Jan 28, 2025
2 parents 1fcade5 + 2408ee5 commit e6eed2d
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion acceptance/logs/expected.log
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ INFO: 📖 loading runway configuration
DEBUG: attempting to load config from acceptance/config/config.yml
INFO: ✅ loaded configuration successfully
INFO: 🚚 2 projects loaded
INFO: 🛫 starting runway - version: v0.5.1
INFO: 🛫 starting runway - version: v0.5.2
INFO: 📦 starting project project-1
INFO: 🕐 scheduling event with interval 3s for project-1
INFO: 📦 starting project project-2
Expand Down
2 changes: 1 addition & 1 deletion shard.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: runway
version: 0.5.0
version: 0.5.2

authors:
- GrantBirki
Expand Down
2 changes: 1 addition & 1 deletion src/runway/events/github_deployment.cr
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ class GitHubDeployment < BaseEvent
# the first deployment to have an "in_progress" status will be the one we're looking for
# however, the "in_progress" status must be the most recent status for the deployment or we'll ignore it
deployments.each do |deployment|
deployment_id = deployment.id.to_i32
deployment_id = deployment.id
statuses = @github.list_deployment_statuses(@event.repo.not_nil!, deployment_id, per_page: 100)
statuses = statuses.records

Expand Down
2 changes: 1 addition & 1 deletion src/runway/services/github.cr
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ module Runway
end
end

def list_deployment_statuses(repo : String, deployment_id : Int32, per_page : Int32 = 30) : Octokit::Connection::Paginator(Octokit::Models::DeploymentStatus)
def list_deployment_statuses(repo : String, deployment_id : Int64, per_page : Int32 = 30) : Octokit::Connection::Paginator(Octokit::Models::DeploymentStatus)
Retriable.retry do
check_rate_limit!
@client.list_deployment_statuses(repo, deployment_id, per_page: per_page)
Expand Down
2 changes: 1 addition & 1 deletion src/version.cr
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Runway
VERSION = "v0.5.1"
VERSION = "v0.5.2"
end

0 comments on commit e6eed2d

Please sign in to comment.