feat(bam): add public constructors for IterAlignedBlocks and IterIntrons#506
Open
VedantMadane wants to merge 2 commits intorust-bio:masterfrom
Open
feat(bam): add public constructors for IterAlignedBlocks and IterIntrons#506VedantMadane wants to merge 2 commits intorust-bio:masterfrom
VedantMadane wants to merge 2 commits intorust-bio:masterfrom
Conversation
johanneskoester
approved these changes
Jan 29, 2026
Contributor
|
Good idea! May I ask you to fix the clippy errors? |
Pull Request Test Coverage Report for Build 21205858316Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
- Add IterAlignedBlocks::new(pos, cigar) constructor - Add IterIntrons::new(pos, cigar) constructor - Allow external construction without BamRecordExtensions - Add comprehensive documentation and examples - Add unit tests for both constructors Resolves issue rust-bio#472: Add public constructor for public structs
5937284 to
12e00d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds public constructors for IterAlignedBlocks and IterIntrons structs to allow external construction without BamRecordExtensions access.
Resolves issue #472. Previously these public structs had private fields making external construction impossible.
Changes:
Example: let iter = IterAlignedBlocks::new(100, cigar_vec);