verify: fix test existence check#630
Merged
tcharding merged 1 commit intoJun 18, 2026
Merged
Conversation
RuslanProgrammer
requested review from
jamillambert and
tcharding
as code owners
Collaborator
There was a problem hiding this comment.
I get a bunch of missing tests that do exist when checking on v30. e.g. scanblocks, scantxoutset. I didn't go through them all to see if they are in the output file and there are no typos or missing _.
EDIT: After further looking this looks like issues in the test names and other real problems.
Member
|
FWIW on this branch I get: cargo run -- --tests /tmp/test29.out 29
Compiling verify v0.1.0 (/home/tobin/build/corepc/verify)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.22s
Running `/home/tobin/~/.cache/cargo/debug/verify --tests /tmp/test29.out 29`
Checking that the v29::METHOD data list is correct ...
Correct ✓
Checking that the rustdoc version specific rustdocs list is correct ...
Correct ✓
Checking that the status claimed in the version specific rustdocs is correct ...
found integration test for untested method: loadtxoutset
missing integration test: savemempool
missing integration test: scanblocks
missing integration test: scantxoutset
missing integration test: getmininginfo
missing integration test: getnetworkhashps
missing integration test: getprioritisedtransactions
missing integration test: submitblock
missing integration test: descriptorprocesspsbt
missing integration test: signrawtransactionwithkey
missing integration test: getbalances
missing integration test: importprivkey
missing integration test: importwallet
missing integration test: newkeypool
missing integration test: setlabel
missing integration test: simulaterawtransaction
status verification failed (16 issue(s))
Incorrect ✗
Checking that 'Returns' column matches model requirements ...
Correct ✓
Checking that corepc-types re-exports are complete ...
Correct ✓
Error: verification failed (1 check(s) failed)(After creating test output with: |
Member
|
Thanks for looking into this @RuslanProgrammer! Appreciate your effort. |
Open
jamillambert
approved these changes
Jun 17, 2026
tcharding
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #629
Handling
test_existsfunction correctly, instead of treating everything non-error as success/failure.