fix: make Hrp Hash case-insensitive to match PartialEq#278
Open
alexgrad42 wants to merge 2 commits into
Open
Conversation
Member
|
I think this is wrong because if you hash two The std impl for |
alexgrad42
force-pushed
the
fix/hrp_hash_partial_eq
branch
from
1023b92 to
e96fad7
Compare
Contributor
Author
|
I've added the length + extracted the test into separate commit, please check |
Fixes the Hash implementation for the Hrp struct to iterate over lowercase bytes instead of hashing the raw internal buffer. This restores the core invariant where `a == b` implies `hash(a) == hash(b)`. Fixes: rust-bitcoin#275
Fixes the Hash implementation for the Hrp struct to iterate over lowercase bytes instead of hashing the raw internal buffer. This restores the core invariant where `a == b` implies `hash(a) == hash(b)`. The commit only adds a new test to reproduce the issue, no real fix. Fixes: rust-bitcoin#275
alexgrad42
force-pushed
the
fix/hrp_hash_partial_eq
branch
from
e96fad7 to
0232d7b
Compare
Member
|
In ad99e2f: now this has two length prefixes and does an unnecessary copy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Hash implementation for the Hrp struct to iterate over lowercase bytes instead of hashing the raw internal buffer. This restores the core invariant where
a == bimplieshash(a) == hash(b).Fixes: #275