Whitelist cfg attrs and bump nightly version #2785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C-bitcoin
Pull Request Test Coverage Report for Build 9192394789Details
💛 - Coveralls |
apoelstra
force-pushed
the
2024-05--cfg-attrs
branch
from
e3b7833 to
9e7ac4e
Compare
epage
reviewed
May 21, 2024
| @@ -79,3 +79,6 @@ required-features = ["std", "rand-std", "bitcoinconsensus"] | |||
|
|
|||
| [[example]] | |||
| name = "sighash" | |||
|
|
|||
| [lints.rust] | |||
| unexpected_cfgs = { level = "deny", check-cfg = ['cfg(bench)', 'cfg(fuzzing)', 'cfg(kani)', 'cfg(mutate)', 'cfg(rust_v_1_60)'] } | |||
There was a problem hiding this comment.
rust_v_1_60
Shouldn't this be set in your build.rs where the cfg is defined?
There was a problem hiding this comment.
@epage not a bad idea -- but I kinda like having everything defined here because I can easily pull stuff out of TOML files, and not-so-easily pull stuff out of .rs files, in case I want to generate a summary of all the cfg options or do some CI sanity-checks on them or something.
tcharding
reviewed
May 21, 2024
units/Cargo.toml
Outdated
| @@ -29,3 +29,6 @@ serde = { version = "1.0.103", default-features = false, features = ["derive"], | |||
| [dev-dependencies] | |||
| serde_test = "1.0" | |||
| serde_json = "1.0" | |||
|
|
|||
| [lints.rust] | |||
| unexpected_cfgs = { level = "warn", check-cfg = ['cfg(kani)'] } | |||
There was a problem hiding this comment.
Just out of interest, why is this level = "warn" and the others are level = "deny"?
There was a problem hiding this comment.
They should all be deny. I think I just messed one up.
apoelstra
force-pushed
the
2024-05--cfg-attrs
branch
from
9e7ac4e to
30a4825
Compare
tcharding
approved these changes
May 22, 2024
apoelstra
added a commit
to apoelstra/rust-bitcoin
that referenced
this pull request
May 24, 2024
In rust-bitcoin#2785 I modified fuzz/Cargo.toml without updating the Cargo.toml generating script. Oops. Fix that.
This was referenced May 30, 2024
tcharding
added a commit
to tcharding/rust-jsonrpc
that referenced
this pull request
May 31, 2024
As we did in rust-bitcoin/rust-bitcoin#2785. rust-lang/rust#124800 has been fixed and we can update our nightly version by whitelisting all cfgs that are used.
apoelstra
added a commit
that referenced
this pull request
Oct 15, 2024
d99b256 Remove explicit borrow (Tobin C. Harding) 7965e72 Fix rustdoc lint warnings (Tobin C. Harding) e75e7f4 Remove deprecated legacy numeric methods (Divyansh Gupta) 87e353b Update nightly version (Tobin C. Harding) 753972d cargo: whitelist all cfgs used in this repo (Andrew Poelstra) 62eca12 crypto: enable and fix accidentally disabled unit test (Andrew Poelstra) Pull request description: Backport a bunch of patches to get the clippy job passing. - the first two patches from #2785 - Update `nightly-toolchain` - the single patch from #2667 After rebase I just manually fixed all remaining lint warnings/errors ACKs for top commit: apoelstra: ACK d99b256 successfully ran local tests; nice! especially updating the rust-nightly version, which probably was not strictly necessary. will one-ack merge Tree-SHA512: 895807dc9402f88f7d2207799c50ab96841eaeb6ee1aaf8cd1a735365cc9728025c80c8c9fae0d28d4c8de6d3685121b162225a63ea64e72b749d9960a28f10e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/rust#124800 has been fixed and we can update our nightly version by whitelisting all cfgs that are used.
There was one place where we had an old
cfg(feature = "no-std")despite having removed the feature. By removing that cfg check we re-enabled a previously disabled test.