Merges rust-lightning's lightning-block-sync HTTP logic #201
+1,372
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces rust-jsonrpc by rust-lightning's lightning-block-sync HTTP logic. Kind of POC atm, still needs to handle sync / async properly
|
Concept ACK. Yay fewer deps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first approach to address #166 by merging lightning-block-sync rpc and http logic into here.
The code still has some fixme's, and
async/synchas not properly been handled.I'm mainly looking for feedback at this point, in order to keep pushing this approach or switch gears and address this in a different way.