Ugrade bitcoin dependency to v0.31.0-rc1
#310
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
10-16-ugrade-bitcoin
branch
from
b45c12c to
96574c1
Compare
Loads of deps break MSRV at the moment because the Rust ecosystem is upgrading to edition 2021 left, right, and centre without bumping crate versions. Pin various crates in CI for MSRV test run, do it in the CI script instead of in the github action.
Not sure why these formatting issues are present on `master`, seems we run the formatter with a stable toolchain in CI? Run `cargo fmt`, no manual changes.
Upgrade to the rc1 release for upcoming bitcoin v0.31.0 by doing: - Remove dependency on `bitcoin_private`, use hex stuff from `bitcoin::hex` (re-export of `hex-conservative`). - Do type renames. - Add a couple of type annotations when parsing `Address`.
tcharding
force-pushed
the
10-16-ugrade-bitcoin
branch
from
96574c1 to
f3d66cf
Compare
|
Typo in branch name, closing in favour of #311. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a merge candidate, it serves the following purposes:
Demonstrate what likely needs doing once we drop the
bitcoin v0.31.0release.Uncover any bugs in the rc release.
Patch 1: Pin deps for MSRV test run
Patch 2: Runsthe formatter so as not to clutter the second patch with random formattting changes.
Patch 3: Do the upgrade
Note we no longer need to depend on
bitcoin-private, the hex stuff is inhex-conservativenow (re-exported bybitcoin).