new embedded-sdmmc-types crate#245
Open
robamu wants to merge 1 commit into
Open
Conversation
d4ab356 to
21ed7e8
Compare
b7cdb95 to
53916ea
Compare
Contributor
Author
|
we could do a full re-export of the types trait in |
f3f9218 to
b1a7bc1
Compare
Contributor
Author
|
I also updated the README now. the top-level README has a mono-repo style short description with links to the contained libraries. the previous documentation was mostly moved to |
- Extract fundamental traits and types into separate crate - HALs or other libraries which just want to provide `embedded-sdmmc` support can include this library instead of the full `embedded-sdmmc` library to implement driver support. - Extended `sd_card_init` example to also implement the block device trait. It also only depends on `embedded-sdmmc-types` types now.
b1a7bc1 to
3ef1dda
Compare
thejpster
reviewed
May 15, 2026
| /// SD card mock. | ||
| /// | ||
| /// This basically behaves like a virtual SD card. Currently, this mock simulates a Ver2.00 or later | ||
| /// This basically behaves like a virtual SD card controller with a connected virtual SD card.s |
Member
There was a problem hiding this comment.
Suggested change
| /// This basically behaves like a virtual SD card controller with a connected virtual SD card.s | |
| /// This basically behaves like a virtual SD card controller with a connected virtual SD card. |
| @@ -0,0 +1,35 @@ | |||
| # Embedded SD/MMC [](https://crates.io/crates/embedded-sdmmc-types) [](https://docs.rs/embedded-sdmmc-types) | |||
|
|
|||
| Embedded SD/MMC Types Library | |||
Member
There was a problem hiding this comment.
This file has two headings (a === underline works like a # I think) which looks odd?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
embedded-sdmmcsupport can include this library instead of the full
embedded-sdmmclibrary to implement driver support. I would expect
embedded-sdmmc-typesto change lessfrequently than the
embedded-sdmmccrate using it. It allowsembedded-sdmmcto evolvewithout breaking the fundamental traits.
sd_card_initexample to also implement the block devicetrait. It also only depends on
embedded-sdmmc-typestypes now.