cortex-m-semihosting: make semihosting macros compatible with 1-arg format strings #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suaviloquence
force-pushed
the
1/semihosting-macros
branch
from
ff40d55 to
8c2f5ad
Compare
| }; | ||
| ($s:expr, $($tt:tt)*) => { | ||
| $crate::export::hstderr_fmt(format_args!(concat!($s, "\n"), $($tt)*)) | ||
| $crate::export::hstderr_fmt(format_args!("{}\n", format_args!($s, $($tt)*))) |
There was a problem hiding this comment.
Is the double nested format_args! required here? Was there some use case that didn't work with the previous method of using concat!?
There was a problem hiding this comment.
Yes, sorry I meant to take a note of it - format_args! doesn't expand captures in the format string literal if it is generated by a macro:
From rust-lang/rust#106824, it should get flattened into a single format_args!/Arguments call.
There was a problem hiding this comment.
yikes - thanks for the clarification.
|
As a point of reference, the semihosting crate does it like this: https://docs.rs/semihosting/0.1.18/src/semihosting/macros.rs.html. You could make the argument we should deprecate this crate and recommend people use that one. |
jonathanpallant
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #581