Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix building without yaml feature #877

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Fix building without yaml feature #877

merged 3 commits into from
Oct 23, 2024

Conversation

jannic
Copy link
Member

@jannic jannic commented Oct 23, 2024

Closes #875

@jannic jannic requested a review from a team as a code owner October 23, 2024 16:00
@jannic jannic mentioned this pull request Oct 23, 2024
Closed
@Emilgardis Emilgardis closed this Oct 23, 2024
@Emilgardis Emilgardis reopened this Oct 23, 2024
Emilgardis
Emilgardis approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I like this better. LGTM

(accidentally closed the pr, thought I was on my pr :D)

@Emilgardis Emilgardis enabled auto-merge October 23, 2024 16:32
@Emilgardis Emilgardis added this pull request to the merge queue Oct 23, 2024
Merged via the queue into rust-embedded:master with commit 4563540 Oct 23, 2024
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Current master branch does not build with --no-default-features
2 participants
@jannic @Emilgardis