Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N50: sm64jsarchive (fixed) #1477

Merged
merged 11 commits into from
Apr 11, 2024
Merged

N50: sm64jsarchive (fixed) #1477

merged 11 commits into from
Apr 11, 2024

Conversation

GManTheMarioGuy
Copy link
Contributor

@GManTheMarioGuy GManTheMarioGuy commented Apr 10, 2024

Part of #1474

Copy link
Contributor Author

@GManTheMarioGuy GManTheMarioGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also yes this is from in game of sm64jsarchive with the working mmo servers lol
(Commenting on the sm64jsarchive picture)

@janhohenheim
Copy link
Collaborator

Thanks for the contribution! Two points!

  • The style checks are failing, but it seems easy to fix:
    image
  • This seems to be a JS project. Could you elaborate on what this has to do with Rust?

@GManTheMarioGuy
Copy link
Contributor Author

Thanks for the contribution! Two points!

* The style checks are failing, but it seems easy to fix:
  ![image](https://private-user-images.githubusercontent.com/9047632/321236065-03d42837-e693-4c9f-b075-80adcec79480.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTI3NjUyNjgsIm5iZiI6MTcxMjc2NDk2OCwicGF0aCI6Ii85MDQ3NjMyLzMyMTIzNjA2NS0wM2Q0MjgzNy1lNjkzLTRjOWYtYjA3NS04MGFkY2VjNzk0ODAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDQxMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA0MTBUMTYwMjQ4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OTU3ZDNkZDczYjI0MmFhMGI1NjM2M2MzZWU4NDkyNjk5ZjQyZGFiMmIyYWFmMDAwMWFkOTQyZjQyMDNlOWM1ZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.Z91F9ZPnytYa8nFiFbqr2G7GUUA9YrwLdhk_FJzoY-c)

* This seems to be a JS project. Could you elaborate on what this has to do with Rust?

The backend is in rust also your check failed on the image part of it (sm64jsarchive.png) 9b46226

@GManTheMarioGuy
Copy link
Contributor Author

@janhohenheim I tried fixing it please check again also I allowed edits by maintainers just incase.

@janhohenheim
Copy link
Collaborator

Aah I see. Cool project!

@janhohenheim
Copy link
Collaborator

@uuphoria2 I can fix the lints myself later if you are otherwise finished with the PR :)

@janhohenheim janhohenheim mentioned this pull request Apr 10, 2024
20 tasks
@GManTheMarioGuy
Copy link
Contributor Author

@uuphoria2 I can fix the lints myself later if you are otherwise finished with the PR :)

Im running the rust servers for sm64jsarchive right now so note I might not be as active

@GManTheMarioGuy
Copy link
Contributor Author

GManTheMarioGuy commented Apr 11, 2024

@uuphoria2 I can fix the lints myself later if you are otherwise finished with the PR :)

Please do so, as I dont have much time to work on this pull request cuz im the only one maintaining the rust servers within docker for sm64jsarchive.

@janhohenheim
Copy link
Collaborator

janhohenheim commented Apr 11, 2024

@uuphoria2 will do, just need some time myself. The newsletter will be sent out on the the 3rd of May, so there's no rush :)

Update: will do this after #1480

Copy link
Collaborator

@janhohenheim janhohenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done now; thanks again for your submission!

@janhohenheim janhohenheim merged commit 21e43f8 into rust-gamedev:source Apr 11, 2024
1 check passed
@GManTheMarioGuy
Copy link
Contributor Author

Done now; thanks again for your submission!

Thank you so much.

@janhohenheim
Copy link
Collaborator

Thanks for the update, I'll make sure to update the info once the editorial period starts :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants