-
Notifications
You must be signed in to change notification settings - Fork 343
Release N50 #1496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release N50 #1496
Conversation
Co-authored-by: Jan Hohenheim <[email protected]>
Co-authored-by: Thierry Berger <[email protected]>
Initial version is done; feedback is welcome :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking to hold merge on my review (expected in <24h) 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a separate PR into this branch with many changes, that should be merged 👍🏻 #1501
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some additional items to look at
Co-authored-by: Forest Anderson <[email protected]>
@Vrixyz I know you've distanced yourself in the past from phrases like "Jan and Thierry have led the newsletter revival", which is why I read the announcement the way I did originally. Could you check the wording in the announcement after @AngelOnFira's changes? |
@janhohenheim I feel like you deserve more credits in the wording but I'm fine with it 👍 |
Then I'll leave it to @AngelOnFira on how to phrase it. I don't want to toot my own horn too much, haha. |
In rewording that paragraph, one item I tried to emphasize is that there still is a team behind the newsletter, it's not just a single person. I'm a bit adverse to giving off the impression that a single person is running everything without support, while also stating that the previous issue hiatus was a result of maintainer burnout 😅 if needed, I can try rewording the sentence in a different way. In regards of credit, I think you both have done quite a lot in getting things rolling, so I'm happy with both names mentioned 👍🏻 |
Your reasoning makes sense to me, thanks for the explanation :) Let's leave it like this. |
From discussions on Discord. I don't like calling out specific names in public issues without their consent, but some very active community members wrote this, which makes me believe their opinion is representative of the community. Of course, if the survey tells us something different, I'll change my stance accordingly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Everything looks good to me 🦀
Resolves #1474
Scheduled for 2024-05-03