Add example of linking against a C++ shared library#725
Open
domfarolino wants to merge 1 commit intorust-lang-nursery:masterfrom
Open
Add example of linking against a C++ shared library#725domfarolino wants to merge 1 commit intorust-lang-nursery:masterfrom
domfarolino wants to merge 1 commit intorust-lang-nursery:masterfrom
Conversation
0464433 to
61a45e8
Compare
AndyGauge
requested changes
Feb 14, 2026
Contributor
AndyGauge
left a comment
There was a problem hiding this comment.
Thanks for the contribution! This is a great addition to the cookbook, but there are several technical and naming inconsistencies that need to be addressed before it's ready for merge:
- Title vs. Content: The section header is titled "Compile and link statically...", but the content describes dynamic linking to a shared library (
.so). - Filename Inconsistencies:
- The prose mentions
src/mylibrary.handsrc/mylibrary.cc. - Code blocks are labeled
src/library.candsrc/library.h. - The
Makefileexpectssrc/mylibrary.candsrc/mylibrary.h. src/library.cincludes"api.h", which isn't defined (should likely belibrary.hormylibrary.h).
- The prose mentions
- Language/Compiler Mismatch: The implementation file is labeled
.cbut contains C++ code (<iostream>,std::cout). It should probably be named.cppor.cc, and the Makefile should reflect this. - Build Search Path:
cargo:rustc-link-search=native=.assumes the library is in the root during build. While simple, it's often better to referenceCARGO_MANIFEST_DIRor provide instructions on where the user should run the Makefile to ensure the.sois found.
Requesting changes to align the filenames, headers, and terminology!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #294 and contributes to #328.
Please take a look @budziq, I'd love for the cookbook to have a simple example of Rust dynamically linking against a C/C++ shared library through a C ABI.
Things to check before submitting a PR
cargo xtask test allhttps://docs.rs/tar/*/tar/struct.Entry.html.unwrap()in basic helper code I think is OK here? But I'd love for someone to confirm!