Skip to content

Commit 3e8a932

Browse files
committed
WIP switch to GenerateIntoSlashTemp to test whether that fixes issue when testing on CI.
1 parent 34a1a2d commit 3e8a932

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

tests/common/which_temp.rs

+7-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,13 @@ pub trait WhichTempDirectory {
1616
// Doing so has two drawbacks: 1. You need to clean-up the
1717
// generated directory yourself, and 2. You risk race conditions with
1818
// concurrent test runs.
19-
pub(crate) type WhichTempDir /*: WhichTempDirectory*/ = GenerateIntoFreshTemp;
19+
//
20+
// If you cange this to `GenerateIntoFreshTemp`, you get a fresh directory
21+
// (rooted at whatever is returned from `tempfile::tempdir()`). This reduces
22+
// race conditions (note that `cargo-bisect-rustc` still stores data in shared
23+
// locations like `~/.rustup`, so races can still arise) and allows the test
24+
// suite to clean up the directory itself.
25+
pub(crate) type WhichTempDir /*: WhichTempDirectory*/ = GenerateIntoSlashTemp;
2026

2127
/// Using `GenerateIntoFreshTemp` yields a fresh directory in some
2228
/// system-dependent temporary space. This fresh directory will be autoamtically

0 commit comments

Comments
 (0)