Add xtensa to list of soft math targets. #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase on the latest master to fix the CI failure (fixed in #437)? |
MabezDev
force-pushed
the
feature/xtensa-soft-math
branch
from
7022ffc to
5d6e20d
Compare
MabezDev
force-pushed
the
feature/xtensa-soft-math
branch
from
5d6e20d to
4833f5f
Compare
tgross35
added a commit
to tgross35/compiler-builtins
that referenced
this pull request
Feb 24, 2025
Add `ceilf16` and `ceilf128`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am right in thinking these software impls only get used if there isn't hardware accelerated support for the current target? I.e some xtensa chips will be able to accelerate
fmafor example, adding this change wouldn't stop that from happening on chips that support those hardware instructions, right?