Set overflow-y: hidden on navbar #1711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some unusual circumstances, parts of the navbar can overflow vertically. This interferes with the main body content in surprising ways, so we want to prevent that.
github-actions
bot
added
the
S-waiting-on-review
jyn514
approved these changes
Apr 9, 2022
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some unusual circumstances, parts of the navbar can overflow vertically. This interferes with the main body content in surprising ways, so we want to prevent that.
Fixes #1669. I've reproduce the issue from #1669 locally by installing the copy of Fira Sans from this comment, and can confirm that the overflow-y setting fixes the problem.