Skip to content

invalidate CDN in more build error cases, & invalidate after yank / crate-delete #1864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2022
Merged

invalidate CDN in more build error cases, & invalidate after yank / crate-delete #1864

merged 1 commit into from
Oct 5, 2022

Conversation

syphar
Copy link
Member

@syphar syphar commented Sep 30, 2022

Fixes #1862 and #1861.

@syphar
Copy link
Member Author

syphar commented Sep 30, 2022

r? @Nemo157 @jsha

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Sep 30, 2022
@syphar syphar marked this pull request as draft September 30, 2022 05:48
@syphar syphar force-pushed the invalidate-cdn-after-yank branch from ac1fde8 to c5195a5 Compare September 30, 2022 05:52
@syphar syphar marked this pull request as ready for review September 30, 2022 05:53
@syphar syphar mentioned this pull request Sep 30, 2022
Merged
@syphar
Copy link
Member Author

syphar commented Oct 4, 2022

ping @rust-lang/docs-rs ?

Nemo157
Nemo157 reviewed Oct 4, 2022
View reviewed changes
jsha
jsha approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. I think we need to resolve the question about CloudFront's invalidation API, but since this change is moving that code around, not changing it, I'm okay deferring the question for a followup.

@syphar syphar merged commit dd66a73 into rust-lang:master Oct 5, 2022
@syphar syphar deleted the invalidate-cdn-after-yank branch October 5, 2022 06:55
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Oct 5, 2022
@syphar syphar mentioned this pull request Oct 5, 2022
Open
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Oct 8, 2022
@syphar syphar mentioned this pull request Feb 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nemo157 Nemo157 Nemo157 left review comments

@jsha jsha jsha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

invalidate pages when release is yanked
3 participants
@syphar @Nemo157 @jsha