[WIP] Adding a configuration option to specify rustc version #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is maybe not as elegant as it could be but should hopefully work? I'm not 100% sure how the crates are built (i.e. how the working directories are built and scoped) so I hope that `rustup` is invoked in the correct directory. If that's not the case, then this can be changed. Additionally I am aware that this is a **work in progress** and further changes are required on docs.rs and the compilers part to make "hot-swapping" versions easier. See rust-lang#225 for more details. This PR addresses rust-lang#228
|
Thank you for your contribution! Unfortunately, this PR was written for the old builder, which we stopped using last September for sandboxing reasons (see https://blog.rust-lang.org/2019/09/18/upcoming-docsrs-changes.html for details). It looks like the PR would have to be rewritten from scratch to work with Rustwide, so I'm closing this. If you would like help porting it, feel free to reply here or on discord and I'd be happy to help you out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is maybe not as elegant as it could be but should hopefully work.
I'm not 100% sure how the crates are built (i.e. how the working directories are
built and scoped) so I hope that
rustupis invoked in the correct directory.If that's not the case, then this can be changed.
Additionally I am aware that this is a work in progress and further changes
are required on docs.rs and the compilers part to make "hot-swapping" versions
easier. See #225 for more details.
This PR addresses #228