-
Notifications
You must be signed in to change notification settings - Fork 39
feat: add issue template for changes #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PLeVasseur
wants to merge
6
commits into
rust-lang:main
Choose a base branch
from
PLeVasseur:feat/add-issue-template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0243555
feat: add issue template for changes
PLeVasseur 7e5b00e
fix: add SPDX tags
PLeVasseur 9c1b945
chore: remove chapter dropdown; utilize areas
PLeVasseur cefd25d
fix: modify SPDX-FileCopyRightText to Rust Project standards
PLeVasseur 505331a
chore: make FLS ID placeholder more obvious
PLeVasseur 439b1ff
fix: update to sentence case for category of change dropdown
PLeVasseur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| # SPDX-License-Identifier: MIT OR Apache-2.0 | ||
| # SPDX-FileCopyrightText: The Rust Project Developers | ||
|
|
||
| name: Change | ||
| description: File a change for the FLS | ||
| title: "[Change]: " | ||
| labels: ["change intake"] | ||
| assignees: | ||
| - PLeVasseur | ||
| body: | ||
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| Thank you for contributing a change! | ||
| - type: input | ||
| id: title | ||
| attributes: | ||
| label: Change description | ||
| description: Description of what is intended to be changed | ||
| placeholder: Fix description of lexing due to xx | ||
| validations: | ||
| required: true | ||
| - type: dropdown | ||
| id: area | ||
| attributes: | ||
| label: Area | ||
| description: Which part of the language does this fall under? | ||
| options: | ||
| - ABI | ||
| - async / await | ||
| - attributes | ||
| - closures | ||
| - conditional compilation | ||
| - const evaluation | ||
| - conventions | ||
| - destructors | ||
| - diagnostics | ||
| - "edition: 2015" | ||
| - "edition: 2018" | ||
| - "edition: 2021" | ||
| - "edition: 2024" | ||
| - editions | ||
| - generics | ||
| - glossary | ||
| - grammar | ||
| - inline assembly | ||
| - linkage | ||
| - macros | ||
| - method call | ||
| - panic | ||
| - patterns | ||
| - proc macros | ||
| - resolution (names, paths, namespaces, preludes, ...) | ||
| - types | ||
| - type inference | ||
| - type layout | ||
| - undefined behavior | ||
| - N/A | ||
| validations: | ||
| required: true | ||
| - type: dropdown | ||
| id: category | ||
| attributes: | ||
| label: Category | ||
| description: What kind of change is this? | ||
| options: | ||
| - Bug | ||
| - Formatting | ||
| - Improvement to non-prose section | ||
| - Language cleanup | ||
| - New content | ||
| - Other | ||
| validations: | ||
| required: true | ||
| - type: input | ||
| id: fls-id | ||
| attributes: | ||
| label: FLS Paragraph ID | ||
| description: | | ||
| The Paragraph ID from the FLS corresponding to what this Guideline covers. | ||
| Easiest way to obtain this is to navigate to the | ||
| [FLS](https://rust-lang.github.io/fls), right click a section ID | ||
| (e.g. `4.2:2`), inspect, and then find it in the pane which opens in | ||
| your browser. | ||
|
|
||
| **Note**: New content need not fill this in. | ||
| placeholder: fls_deaddeadbeef | ||
| validations: | ||
| required: false | ||
| - type: textarea | ||
| id: change-description | ||
| attributes: | ||
| label: Change description (extended) | ||
| description: | | ||
| A longer description of the intended change, including background and | ||
| details on in what way the FLS is improved by the change. | ||
| placeholder: Fix description of lexing due to xx, since under conditions yy it's possible for zz to occur. | ||
| validations: | ||
| required: true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # SPDX-License-Identifier: MIT OR Apache-2.0 | ||
| # SPDX-FileCopyrightText: The Rust Project Developers | ||
|
|
||
| blank_issues_enabled: true |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an aside, perhaps this points toward us wanting to expose these identifiers more readily on the front-end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, agreed. I think something like display on hover over the section numbering would be really nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened an issue for it: #586